ListOffsetsRequest should only be sent to the leader replica (CI) #4754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emasab
changed the title
|
@emasab do you think this PR could be merged soon? I saw there were some CI issues on previous iterations of this PR but this one looks green |
milindl
approved these changes
Jul 26, 2024
| @@ -111,6 +110,11 @@ static void do_test_offset_reset(const char *auto_offset_reset) { | |||
| else | |||
| test_consumer_poll(auto_offset_reset, c, 0, 1, 0, msgcnt, NULL); | |||
|
|
|||
| /* send another batch of messages to ensure the consumer isn't stuck */ | |||
There was a problem hiding this comment.
I think it's a good idea to expand on why exactly we add this and why the consumer was getting stuck, alternatively, we can provide the issue # . Without that, it'll be a bit difficult for future readers.
CHANGELOG.md
Outdated
| * Fix segfault when using long client id because of erased segment when using flexver. (#4689) | ||
| * Update bundled lz4 (#4726) | ||
| * Fix segfault when using long client id because of erased segment when using flexver. (#4689) | ||
| * Fix for a loop of ListOffset requests, happening in a Fetch From Follower |
There was a problem hiding this comment.
Fix changelog for this to be in 2.5.1
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
7 tasks
airlock-confluentinc
bot
force-pushed
the
dev_kphelps_list-offsets-leader
branch
2 times, most recently
from
4d463c9
to
89369d8
Compare
airlock-confluentinc
bot
force-pushed
the
dev_kphelps_list-offsets-leader
branch
from
89369d8
to
7d09ee5
Compare
milindl
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4616 from an internal branch due to CI issues